On Mon 21-11-11 21:03:43, Wu Fengguang wrote: > Add an upper limit to balanced_rate according to the below inequality. > This filters out some rare but huge singular points, which at least > enables more readable gnuplot figures. > > When there are N dd dirtiers, > > balanced_dirty_ratelimit = write_bw / N > > So it holds that > > balanced_dirty_ratelimit <= write_bw The change makes sense, but do we understand why there are such huge singular points? Are they due to errors in estimation of bandwidth or due to errors in dirtying rate computations (e.g. due to truncates), or something else? Honza > Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx> > --- > mm/page-writeback.c | 5 +++++ > 1 file changed, 5 insertions(+) > > --- linux-next.orig/mm/page-writeback.c 2011-11-17 20:18:03.000000000 +0800 > +++ linux-next/mm/page-writeback.c 2011-11-17 20:18:23.000000000 +0800 > @@ -804,6 +804,11 @@ static void bdi_update_dirty_ratelimit(s > */ > balanced_dirty_ratelimit = div_u64((u64)task_ratelimit * write_bw, > dirty_rate | 1); > + /* > + * balanced_dirty_ratelimit ~= (write_bw / N) <= write_bw > + */ > + if (unlikely(balanced_dirty_ratelimit > write_bw)) > + balanced_dirty_ratelimit = write_bw; > > /* > * We could safely do this and return immediately: > > -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
