Any feedback for this patch? Thanks & Regards, Amit Sahrawat On Fri, Nov 11, 2011 at 9:24 PM, Namjae Jeon <linkinjeon@xxxxxxxxx> wrote: > block plug in mpage_readpages is duplicated with plug of read_pages. So block plug is not needed in mpage_readpages. > > Signed-off-by: Namjae Jeon <linkinjeon@xxxxxxxxx> > Signed-off-by: Amit Sahrawat <amit.sahrawat83@xxxxxxxxx> > --- > fs/mpage.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/fs/mpage.c b/fs/mpage.c > index fdfae9f..643e9f5 100644 > --- a/fs/mpage.c > +++ b/fs/mpage.c > @@ -371,9 +371,6 @@ mpage_readpages(struct address_space *mapping, struct list_head *pages, > sector_t last_block_in_bio = 0; > struct buffer_head map_bh; > unsigned long first_logical_block = 0; > - struct blk_plug plug; > - > - blk_start_plug(&plug); > > map_bh.b_state = 0; > map_bh.b_size = 0; > @@ -395,7 +392,6 @@ mpage_readpages(struct address_space *mapping, struct list_head *pages, > BUG_ON(!list_empty(pages)); > if (bio) > mpage_bio_submit(READ, bio); > - blk_finish_plug(&plug); > return 0; > } > EXPORT_SYMBOL(mpage_readpages); > -- > 1.7.4.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html