On Mon, Nov 14, 2011 at 05:15:23PM +0100, Jan Kara wrote: > There is no reason why task in balance_dirty_pages() shouldn't be killable > and it helps in recovering from some error conditions (like when filesystem > goes in error state and cannot accept writeback anymore but we still want to > kill processes using it to be able to unmount it). Sorry for noticing this so late, but what about killing the balance_dirty_pages_ratelimited wrapper, and only exporting a version that takes a number of pages now that we have to change the signature anyway? I'd recommend to call the new one simply balance_dirty_pages_ratelimited, that will give a compile breakge to anyone using one of the old versions and thus cause them to actually adapt and hopefull check the return value. (and not for this series but soon later - we probably really should call into balance_dirty_pages in larger batch sizes in most places). -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
