On Thu 20-10-11 05:53:44, Christoph Hellwig wrote:
> > diff --git a/fs/sync.c b/fs/sync.c
> > index 3367d04..5fbeee6 100644
> > --- a/fs/sync.c
> > +++ b/fs/sync.c
> > @@ -68,18 +68,26 @@ int sync_filesystem(struct super_block *sb)
> > }
> > EXPORT_SYMBOL_GPL(sync_filesystem);
> >
> > -static void sync_one_sb(struct super_block *sb, void *arg)
> > +static void sync_inodes_one_sb(struct super_block *sb, void *arg)
> > {
> > - if (!(sb->s_flags & MS_RDONLY))
> > - __sync_filesystem(sb, *(int *)arg);
> > + if (!(sb->s_flags & MS_RDONLY)) {
> > + if (!*(int *)arg)
> > + writeback_inodes_sb(sb);
> > + else
> > + sync_inodes_sb(sb);
> > + }
>
> This would be a lot cleaner if you split it into two functions for
> the writeback_inodes_sb and sync_inodes_sb cases.
OK, split to writeback_inodes_one_sb() and sync_inodes_one_sb().
> > -/*
> > - * Sync all the data for all the filesystems (called by sys_sync() and
> > - * emergency sync)
> > - */
> > -static void sync_filesystems(int wait)
> > +
> > +static void sync_fs_one_sb(struct super_block *sb, void *arg)
> > {
> > - iterate_supers(sync_one_sb, &wait);
> > + if (!(sb->s_flags & MS_RDONLY) && sb->s_op->sync_fs)
> > + sb->s_op->sync_fs(sb, *(int *)arg);
> > +}
> > +
> > +static void sync_blkdev_one_sb(struct super_block *sb, void *arg)
> > +{
> > + if (!(sb->s_flags & MS_RDONLY))
> > + __sync_blockdev(sb->s_bdev, *(int *)arg);
> > }
>
> Same here, not having these odd wait/nowait arguments whos address
> is taken in the caller would make the thing a lot more readable.
>
> It would also allow to kill of that nasty __sync_blockdev interface
> eventually.
So you prefer I directly call:
filemap_flush(bdev->bd_inode->i_mapping)
and
filemap_write_and_wait(bdev->bd_inode->i_mapping)
respectively?
Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
