On Fri, Oct 07, 2011 at 10:40:50PM +0200, Jan Kara wrote: > In principle, a filesystem may want to have ->sync_fs() called during sync(1) > although it does not have a bdi (i.e. s_bdi is set to noop_backing_dev_info). > Only writeback code really needs bdi set to something reasonable. So move the > checks where they are more logical. Looks good, but the comment above the check isn't too useful. Either remove it or write something more substancial. Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html