On Tue, Sep 20, 2011 at 12:30:34PM -0400, Christoph Hellwig wrote: > On Fri, Sep 16, 2011 at 11:32:32AM -0500, Shawn Bohrer wrote: > > So for the most part it sounds like this change is needed for DIF/DIX. > > Could we only enable the wait_on_page_writeback() if > > CONFIG_BLK_DEV_INTEGRITY is set? Does it make sense to tie these > > together? > > It will also allow for huge efficiency gains on software raid. There > have been some Lustre patches for that. > > > The other thread in this case is the [flush-8:0] daemon writing back > > the pages. So in our case you could see the spikes every time it wakes > > up to write back dirty pages. While we can control this to some > > extent with vm.dirty_writeback_centisecs and vm.dirty_expire_centisecs > > it essentially impossible to ensure the writeback doesn't coincide > > with us writing to the page again. > > Can you explain how your use case looks in more details? Right now In one case we have an app that receives multicast data from a socket and appends it to one of many memory mapped files. Once it writes the data to the end of the file it updates the header to record the new size. Since we update the header page frequently we are very likely to encounter a stall here as the header page gets flushed in the background. We also have reader processes that check the file header to find the new data since the last time they checked. A stall in updating the header means the readers do not get the latest data. It is also possible that as we append the data to the file a partially filled page at the end of the file could get flushed in the background causing a stall since we append in chunks smaller than 4K. This is less likely though because we have tuned our vm.dirty_writeback_centisecs and vm.dirty_expire_centisecs so that we normally completely fill a page before the OS flushes it. > for example a mlock removes the page from the lru list and thus stops > VM writeback. If such an interface would be useful for you we could > offer an fadvice call that stops writeback entirely, and requires you > to force it when you want it. For the case I described above I'm not sure this would help because we don't know the incoming rate of data so even if we force the sync it could still cause a stall. I do have a second application that is also suffering from these stalls and I believe we could avoid the stalls by using fadvise to disable writeback for a portion of the file and manually sync it ourselves. So this could potentially solve one of my problems. Thanks, Shawn --------------------------------------------------------------- This email, along with any attachments, is confidential. If you believe you received this message in error, please contact the sender immediately and delete all copies of the message. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
