Re: [PATCH 14/18] writeback: control dirty pause time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2011-09-07 at 10:02 +0800, Wu Fengguang wrote:
> > also, do the two other line segments connect on the transition
> > point?
> 
> I guess we can simply unify the other two formulas into one:
> 
>         } else if (period <= max_pause / 4 &&
>                  pages_dirtied >= current->nr_dirtied_pause) {
>                 current->nr_dirtied_pause = clamp_val(
> ==>                                     dirty_ratelimit * (max_pause / 2) / HZ,
>                                         pages_dirtied + pages_dirtied / 8,
>                                         pages_dirtied * 4);
>         } else if (pause >= max_pause) {
>                 current->nr_dirtied_pause = 1 | clamp_val(
> ==>                                     dirty_ratelimit * (max_pause / 2) / HZ,
>                                         pages_dirtied / 4,
>                                         pages_dirtied - pages_dirtied / 8);
>         } 


There's still the clamping, that combined with the various conditionals
make it very hard to tell if the functions are connected or jump around.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux