Re: [RFC] fs, proc: Introduce the /proc/<pid>/map_files/ directory v2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 26, 2011 at 04:06:20PM +0200, Tejun Heo wrote:
> > +struct map_files_info {
> > +	struct file	*file;
> > +	unsigned char	name[16+16+2]; /* max: %016lx-%016lx\0 */
> > +	unsigned long	len;
> > +};
> 
> That's slightly above 50 bytes.

We can use 4 * sizeof(unsigned long) + 2 for name to save a bit on 32 bit
architectures.

BTW, show_map_vma() uses "%08lx-%08lx" to print ->start, ->end. I think
it's good idea to use this here as well to be consistent with
/proc/$PID/{s,}maps

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux