On Fri, Aug 26, 2011 at 03:28:51PM +0300, Kirill A. Shutemov wrote: ... > > > > -static int proc_cwd_link(struct inode *inode, struct path *path) > > +static int proc_cwd_link(struct dentry *dentry, struct inode *inode, struct path *path) > > Put proc_get_link() change in separate patch? > Will do, but let leave it to a final pass, ie when all get agreed on idea and details, ok? Since I'll be re-sending the final version seraparely anyway. ... > > + down_read(&mm->mmap_sem); > > + > > + nr_files = 0; > > + for (vma = mm->mmap; vma; vma = vma->vm_next) { > > + if (vma->vm_file) > > + nr_files++; > > + } > > + if (!nr_files) > > + goto out; > > up_read(&mm->mmap_sem); ? > > > + > > + info = kmalloc(nr_files * sizeof(*info), GFP_KERNEL); > > + if (!info) { > > + ret = -ENOMEM; > > + goto out; > > Ditto. > Yeah, thanks Kirill! -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html