On Fri, Jul 29, 2011 at 06:07:01PM +0200, Stefan Behrens wrote: > Changed the test 079 to be generic for all filesystems and to be > executed for all filesystems. > In src/t_immutable.c which is compiled for Linux only, replaced the > old style XFS and ext2 specific code for setting the append-only and > immutable flags by generic code that makes use of the > ioctl(FS_IOC_SETFLAGS) and ioctl(FS_IOC_GETFLAGS). > Therefore the check for the specific filesystem type was removed. > FS_IOC_GETFLAGS/FS_IOC_SETFLAGS is always used. This code is inside an > '#ifdef FS_IOC_SETFLAGS' block in order to never fail compilation. > Without support for FS_IOC_SETFLAGS, the test completes with _notrun. A little nitpicking for the subject again, I'd rather see something like: xfstests: make t_immutable and 079 filesystem-agnostic > +$timmutable -c $SCRATCH_MNT/$seq >$tmp.out 2>&1 > +if grep -q 'Operation not supported' $tmp.out > +then if grep -q 'Operation not supported' $tmp.out; then please -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
