On Thu, Jul 28, 2011 at 5:19 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > Your clearing of the O_DIRECT flag is. The current handling of O_DIRECT > in the VFS is a bit nasty, but if you have an issue with that fix it up > properly instead of piling more hacks on top of it. > Hmm, I thought that the fact VFS checked for O_DIRECT after ->open() was intentionally giving an opportunity to the filesystem to clear it. But looking backwards now, I think it was my misunderstanding of the intention. I will look deeper into a cleaner implementation of O_DIRECT support. Avati -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html