On 2011.07.26 at 05:34 -0400, Christoph Hellwig wrote: > On Tue, Jul 26, 2011 at 11:15:20AM +0200, Markus Trippelsdorf wrote: > > commit 4e34e719e45, that takes the ACL checks to common code, > > accidentely broke the build when CONFIG_FS_POSIX_ACL is not set: > > > > CC fs/xfs/linux-2.6/xfs_iops.o > > fs/xfs/linux-2.6/xfs_iops.c:1025:14: error: ???xfs_get_acl??? undeclared here (not in a function) > > > > Fix this by declaring xfs_get_acl a static inline function. > > Do you have OPTIMIZE_INLINING enabled? In general I dont think we can > take the address of an inline function, so without this option I far > the code might not compile, in which case we'll need ifdefs around > the inode operation assignment in addition to your patch. No, "# CONFIG_OPTIMIZE_INLINING is not set". I've tested this patch with gcc 4.5.2, 4.6.1 and 4.7.0 and in all cases the kernel builds just fine. -- Markus -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
