Re: [PATCH 1/4] 9p: do no return 0 from ->check_acl without actually checking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 23 Jul 2011 17:36:38 +0200, Christoph Hellwig <hch@xxxxxx> wrote:
> If we do not want to use ACLs we at least need to perform normal Unix
> permission checks.  From the comment I'm not quite sure that's what
> is intended, but if 0p wants to do permission checks entirely on the
> server it needs to do so in ->permission, not in ->check_acl.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Index: linux-2.6/fs/9p/acl.c
> ===================================================================
> --- linux-2.6.orig/fs/9p/acl.c	2011-07-23 16:39:19.200749795 +0200
> +++ linux-2.6/fs/9p/acl.c	2011-07-23 16:39:24.690749763 +0200
> @@ -108,7 +108,7 @@ int v9fs_check_acl(struct inode *inode,
>  		 * On access = client  and acl = on mode get the acl
>  		 * values from the server
>  		 */
> -		return 0;
> +		return -EAGAIN;
>  	}
>  	acl = v9fs_get_cached_acl(inode, ACL_TYPE_ACCESS);
> 

Acked-by: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxxxxxxx>

-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux