On Sat, Jul 23, 2011 at 08:47:22AM +0100, Al Viro wrote: > Anyway, that'll have to wait for tomorrow; I'm going down right now. This > stuff (plus Tim's "mount lock scalability for internal mounts" patch) is > in #untested in usual place. Comments/testing/etc. are welcome... Can't be just pass &inode->i_mode to posix_acl_create for those filesystems that simply write directly into i_mode, instead of keeping it in a local variable? Also the posix_acl_create should be after the function body, not a lot before it. Otherwise looks fine, and passes QA on xfs. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html