On Thu, Jul 21, 2011 at 08:35:23PM +0200, Jan Kara wrote: > > You're also skipping the ->sync_fs and quotasync calls the first round. > Well, kind of. Since writeback is running asynchronously, we have no way > to call ->sync_fs(sb, 0) just after async inode writeback is done (and it > doesn't really make sense to call it before that moment). So we call > synchronous inode writeback first and only then ->sync_fs(). I don't nessecarily say it's a bad thing, but when you do subtile behaviour changes like this it at least needs to be clearly documented in the changelog, or even better split into a patch on it's own. > Where would you like to document the change? commit log. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html