On Wed, 2011-06-22 at 23:58 +0100, Al Viro wrote: > On Wed, Jun 22, 2011 at 06:48:54PM -0400, Trond Myklebust wrote: > > > It is fairly trivial to define a 'struct nfs_path' that takes a > > reference to the dentry and a reference to the super block if you'd > > prefer that we get rid of the 'struct path' in nfs_open_context. > > Er... as opposed to struct dentry *dentry and its ->d_sb? ;-) > See the last few patches in #untested (vfs-2.6.git) doing more > or less that (and nfs4_closedata is just fine with data->inode->i_sb - > it doesn't need to pin any dentries at all; nfs4_opendata and > nfs_open_context need dentry, of course). Sure. As far as we're concerned, the main purpose of the vfsmount in nfs_open_context is to prevent triggering generic_shutdown_super() while we're finishing writebacks. It is convenient to carry that all the way through to the nfs4_closedata, but I agree that it is not necessary... -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
