On Mon, 13 Jun 2011 16:12:52 -0500, Eric Van Hensbergen <ericvh@xxxxxxxxx> wrote:
> Could be wrong, but a quick regression check of your patches fails
> against a legacy server. Are you making sure the new operations are
> properly protected by a .L flag?
How about below diff
[3.0-pending@v9fs]$ git diff
diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
index f40fdc3..436699e 100644
--- a/fs/9p/vfs_inode.c
+++ b/fs/9p/vfs_inode.c
@@ -499,13 +499,15 @@ v9fs_inode_from_fid(struct v9fs_session_info *v9ses, struct p9_fid *fid,
static int v9fs_remove(struct inode *dir, struct dentry *dentry, int flags)
{
- int retval;
struct inode *inode;
+ int retval = -EOPNOTSUPP;
struct p9_fid *v9fid, *dfid;
+ struct v9fs_session_info *v9ses;
P9_DPRINTK(P9_DEBUG_VFS, "inode: %p dentry: %p rmdir: %x\n",
dir, dentry, flags);
+ v9ses = v9fs_inode2v9ses(dir);
inode = dentry->d_inode;
dfid = v9fs_fid_lookup(dentry->d_parent);
if (IS_ERR(dfid)) {
@@ -513,7 +515,8 @@ static int v9fs_remove(struct inode *dir, struct dentry *dentry, int flags)
P9_DPRINTK(P9_DEBUG_VFS, "fid lookup failed %d\n", retval);
return retval;
}
- retval = p9_client_unlinkat(dfid, dentry->d_name.name, flags);
+ if (v9fs_proto_dotl(v9ses))
+ retval = p9_client_unlinkat(dfid, dentry->d_name.name, flags);
if (retval == -EOPNOTSUPP) {
/* Try the one based on path */
v9fid = v9fs_fid_clone(dentry);
related to renameat i have updated to check for -EOPNOTSUPP instead of
-ENOSYS. I am not sure any other dotl server out there is returning
-ENOSYS. We haven't documented what the server should return in case it
doesn't support any specific operation.
-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
