Sage Weil wrote:
Could one of VFS ppl look at this an NACK/ACK it?
I think it's the other dput that you want to remove. 64252c75 is a
misleading because the first hunk has to remove dput() from every exit
path for the function. dentry_unhash is unconditionally doing dget,
though. I think we want
diff --git a/drivers/usb/core/inode.c b/drivers/usb/core/inode.c
index 1b125c2..2278dad 100644
--- a/drivers/usb/core/inode.c
+++ b/drivers/usb/core/inode.c
@@ -389,7 +389,6 @@ static int usbfs_rmdir(struct inode *dir, struct dentry *dentry)
mutex_unlock(&inode->i_mutex);
if (!error)
d_delete(dentry);
- dput(dentry);
return error;
}
Yep, this is the correct one. I added a file and removed it after the hcd
was gone and it only survived your way :)
Are you going to post a complete patch or do you want me to do it?
Sorry I missed this one; I forgot there were filesystems outside of fs/.
Yes, they all over the place including arch/ :)
sage
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
