On Fri 27-05-11 05:46:31, Christoph Hellwig wrote: > this series still leaves a lot of dentry_unhash callsites around, > can you submit some more patches to clan up after it? > > - bfs, sysv, jffs2, jfs, logfs, nilfs2, ubifs and ufs are plain old > unix filesystems and should not have a problem. > - reiserfs is a bit special but really shouldn't need it, also it has > a local copy of vfs_rmdir that needs the call removed as well. I've checked reiserfs code and it handles open-but-deleted directories just fine - it removes directory from parent in rmdir and removes it only in evict_inode - so dentry_unhash() isn't needed AFAIU. > - udf also seems to have normal unix semantics Yes, UDF has standard unix semantics. Honza > - same for omfs > - ecryptfs just passed down requests to the lower fs and thus almost > certainly doesn't need it. > - hfs and hfsplus don't care > - hostsfs doesn't really either > > Cced some more maintainers. In the end each callsite of dentry_unhash > really should have a comment why it's needed or at least why we're > unsure about it. -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
