Re: [PATCH v5 01/21] integrity: move ima inode integrity data management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2011-05-18 at 21:06 -0500, Serge E. Hallyn wrote: 
> Quoting Mimi Zohar (zohar@xxxxxxxxxxxxxxxxxx):
> > Move the inode integrity data(iint) management up to the integrity directory
> > in order to share the iint among the different integrity models.
> 
> You also
> 
>   rename several globally visible ima_* functions, structs, locks etc to
>      integrity_\0
>   replace '20' by SHA1_DIGEST_SIZE
>   remove unnecessary initialization of iint_initialized to 0

Yes, will update the changelog to reflect these changes as well.

> Which all are fine, but probably should be mentioned in changelog,
> along with the magic phrase "no other functional changes" to aid
> reviewers.

Wasn't aware of this.

> > Changelog:
> >    - Rebased on current ima_iint.c
> >    - Define integrity_iint_store/lock as static
> > 
> > Signed-off-by: Mimi Zohar <zohar@xxxxxxxxxx>
> 
> Acked-by: Serge Hallyn <serge.hallyn@xxxxxxxxxx>
> 
> thanks,
> -serge

Thanks!

Mimi 

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux