Re: [PATCH 15/18] exofs: remove unnecessary dentry_unhash on rmdir/rename_dir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/10/2011 07:43 AM, Sage Weil wrote:
> Exofs has no problems with lingering references to unlinked directory
> inodes.
> 
> CC: Boaz Harrosh <bharrosh@xxxxxxxxxxx>
> CC: Benny Halevy <bhalevy@xxxxxxxxxxx>
> CC: osd-dev@xxxxxxxxxxxx
> Signed-off-by: Sage Weil <sage@xxxxxxxxxxxx>

Acked-by: Boaz Harrosh <bharrosh@xxxxxxxxxxx>

Sounds good, Thanks

> ---
>  fs/exofs/namei.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/exofs/namei.c b/fs/exofs/namei.c
> index de252e5..4d70db1 100644
> --- a/fs/exofs/namei.c
> +++ b/fs/exofs/namei.c
> @@ -227,8 +227,6 @@ static int exofs_rmdir(struct inode *dir, struct dentry *dentry)
>  	struct inode *inode = dentry->d_inode;
>  	int err = -ENOTEMPTY;
>  
> -	dentry_unhash(dentry);
> -
>  	if (exofs_empty_dir(inode)) {
>  		err = exofs_unlink(dir, dentry);
>  		if (!err) {
> @@ -251,9 +249,6 @@ static int exofs_rename(struct inode *old_dir, struct dentry *old_dentry,
>  	struct exofs_dir_entry *old_de;
>  	int err = -ENOENT;
>  
> -	if (new_inode && S_ISDIR(new_inode->i_mode))
> -		dentry_unhash(new_dentry);
> -
>  	old_de = exofs_find_entry(old_dir, old_dentry, &old_page);
>  	if (!old_de)
>  		goto out;

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux