On 05/05/2011 03:19 PM, Marco Stornelli wrote:
Il 04/05/2011 19:58, Josef Bacik ha scritto:
+ if (offset>= i_size_read(inode)) {
+ mutex_unlock(&inode->i_mutex);
+ return -ENXIO;
+ }
+ offset = i_size_read(inode);
+ break;
I can add that generic_file_llseek_unlocked means *unlocked* so you
shouldn't unlock any mutex but only return a value. The current version,
in case of SEEK_END uses directly i_size indeed, so maybe I'm missing
something.
Yeah this was a copy+paste mistake, ext4 has it's own llseek that I
modified to run my tests against and then I just copied and pasted it
over to the generic things. I've fixed this earlier, I'll be sending a
refreshed set out soon. Thanks,
Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html