Re: [PATCH 1/2 v2] fs: add SEEK_HOLE and SEEK_DATA flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/04/2011 02:10 PM, Josef Bacik wrote:
On 05/04/2011 03:04 PM, Valdis.Kletnieks@xxxxxx wrote:
On Wed, 04 May 2011 13:58:39 EDT, Josef Bacik said:

-SEEK_HOLE: this moves the file pos to the nearest hole in the file
from the
given position.

Nearest, or next? Solaris defines it as "next", for a good reason -
otherwise
you can get stuck in a case where the "nearest" hole is back towards the
start of the file - and "seek data" will bounce back to the next byte at
the other end of the hole.


Yeah sorry the log says "nearest" but the code says "next", if you look
at it thats how it works. Thanks,

The comments in fs.h say "closest". You may want to change them to "next" as well.

Thanks,
Shaggy
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux