>>>>> "Jeff" == Jeff Moyer <jmoyer@xxxxxxxxxx> writes: Jeff> Hm, I wonder where it makes sense to document this. Maybe Jeff> Documentation/block/queue-sysfs.txt, but I admit I wouldn't have Jeff> looked there while reviewing this code. Maybe we could simply add a comment in the kerneldoc header for blkdev_issue_discard()? I tried to keep Documentation/ABI/ up to date for the topology stuff but it looks like the discard portions never got merged. Probably fell through the cracks. I'll dig up the patch. But as you say -- I'm sure nobody looks. My only motivation for keeping the sysfs ABI doc in sync is to avoid gregkh's wrath... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html