On Thursday, April 28, 2011 01:26:43 AM Casey Schaufler wrote: > On 4/27/2011 5:34 AM, Roberto Sassu wrote: > > The SMACK label of new file descriptors is obtained from the credentials > > set in the 'f_cred' field of the same structure. > > > > Signed-off-by: Roberto Sassu <roberto.sassu@xxxxxxxxx> > > --- > > security/smack/smack_lsm.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c > > index c6f8fca..e3c9e54 100644 > > --- a/security/smack/smack_lsm.c > > +++ b/security/smack/smack_lsm.c > > @@ -1011,7 +1011,7 @@ static int smack_file_permission(struct file *file, int mask) > > */ > > static int smack_file_alloc_security(struct file *file) > > { > > - file->f_security = smk_of_current(); > > + file->f_security = smk_of_task(file->f_cred->security); > > Now hang on. This just looks wrong. You're setting the value of one > field of the file structure to another value in the same file structure. > I don't see that this is what I want. > Hi Casey thanks for the review. The field 'f_cred' stores the credentials of the subject that issued the open. The first patch allows to set this field with the credentials provided to the function get_empty_filp() which may be those of the 'current' process as in the original case, or those provided by a kernel service that called the function dentry_open() directly. Roberto Sassu > > return 0; > > } > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html