On 11-04-14 11:52 AM, Linus Torvalds wrote: > On Thu, Apr 14, 2011 at 8:41 AM, Milton Miller <miltonm@xxxxxxx> wrote: >> >> While checking unregister_filesystem for saftey vs extra calls for >> "ext4: register ext2 and ext3 alias after ext4" I realized that >> the synchronize_rcu() was called on the error path but not on >> the success path. > > Good catch. > > I think this is the bug that then caused us to do commit d863b50ab013 > ("vfs: call rcu_barrier after ->kill_sb()") > > That said, that commit says that "synchronize_rcu()" isn't enough, and > uses rcu_barrier(). > > Which _should_ mean that there are no actual users that care about RCU > events by the time you actually hit "unregister_filesystem()". Is that true of older kernels? (eg. 2.6.38 has the same bug) IOW, is this a -stable candidate? -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html