Hi, On 2010-05-17, Martin K. Petersen wrote: > The change is obviously functionally correct. But I object to the > notion of hw_sectors. The 1:1 mapping of DIF tuples and logical blocks > is even going away in SBC3. So let's not perpetuate that. > > I have a patch in my queue that gets rid of all the hw_sector references > in the integrity code. I'll make sure to include your fix. > > So thanks for spotting this. I obviously haven't tested PI drives with > a 4KB logical block size in combination with device mapper... I'm just curious: did anything come of this? Nowadays gcc 4.6 warns about the same unused nr_sector var smatch warned about, so new readers are coming to the same question of why this function doesn't use hardware sectors. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html