I like this patch very much, but had been waiting for any comments/ack/reviewed-by one of those more familiar with this part of the mm layer. Barring any objections, I plan to merge this (and the performance fix) after some additional review today or tomorrow. On Sun, Mar 27, 2011 at 6:32 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote: > On Wed, 16 Mar 2011 15:15:31 -0400 > Jeff Layton <jlayton@xxxxxxxxxx> wrote: > >> If a process has a dirty page mapped into its page tables, then it has >> the ability to change it while the client is trying to write the data >> out to the server. If that happens after the signature has been >> calculated then that signature will then be wrong, and the server will >> likely reset the TCP connection. >> >> This patch adds a page_mkwrite handler for CIFS that simply takes the >> page lock. Because the page lock is held over the life of writepage and >> writepages, this prevents the page from becoming writeable until >> the write call has completed. >> >> With this, we can also remove the "sign_zero_copy" module option and >> always inline the pages when writing. >> >> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> >> --- >> fs/cifs/cifsfs.c | 4 --- >> fs/cifs/cifsglob.h | 1 - >> fs/cifs/file.c | 62 ++++++++++++++++++++++++++-------------------------- >> 3 files changed, 31 insertions(+), 36 deletions(-) >> > > Steve, can you let me know where we are with this patch? It's not > merged and you haven't commented on it. > > -- > Jeff Layton <jlayton@xxxxxxxxxx> > -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
