Re: [PATCH 1/5] eCryptfs: ecryptfs_keyring_auth_tok_for_sig() bug fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu Mar 17, 2011 at 12:48:50PM +0100, Roberto Sassu <roberto.sassu@xxxxxxxxx> wrote:
> The pointer '(*auth_tok_key)' is set to NULL in case request_key() fails,
> in order to prevent its use by functions calling
> ecryptfs_keyring_auth_tok_for_sig().

Thanks Roberto - I'm going to go ahead and merge this one into my #next
tree. Feel free to drop it from this patch set when you resend.

Tyler

> 
> Signed-off-by: Roberto Sassu <roberto.sassu@xxxxxxxxx>
> ---
>  fs/ecryptfs/keystore.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c
> index c1436cf..4feb78c 100644
> --- a/fs/ecryptfs/keystore.c
> +++ b/fs/ecryptfs/keystore.c
> @@ -1563,6 +1563,7 @@ int ecryptfs_keyring_auth_tok_for_sig(struct key **auth_tok_key,
>  		printk(KERN_ERR "Could not find key with description: [%s]\n",
>  		       sig);
>  		rc = process_request_key_err(PTR_ERR(*auth_tok_key));
> +		(*auth_tok_key) = NULL;
>  		goto out;
>  	}
>  	(*auth_tok) = ecryptfs_get_key_payload_data(*auth_tok_key);
> -- 
> 1.7.4
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux