On Fri, Mar 18, 2011 at 12:07:48PM +0000, Al Viro wrote: > Actually, why do we hold vfsmount_lock over that loop at all? We already > hold namespace_sem, so ->mnt_parent is protected... Argh... No, it isn't. We flip it to final (mnt->mnt_parent = mnt) outside of namespace_sem in release_mounts(). HOWEVER, by that point we have already cleared ->mnt_ns - under namespace_sem. So what we need is check_mnt(new.mnt) in addition to test for root.mnt we already have there. That'll be enough. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
