On Tue, 1 Mar 2011, richard -rw- weinberger wrote: > > +EXPORT_SYMBOL(do_splice_direct); > > I have a question on your patch, why are you using EXPORT_SYMBOL() > instead of EXPORT_SYMBOL_GPL()? > Are you using EXPORT_SYMBOL() because all symbols in fs/splice.c > are exported via EXPORT_SYMBOL()? > > To be more precise, are there any rules to decide when _GPL() should be used? > IMHO we should always use _GPL() for new symbols. I don't think there are any written rules. I'd use EXPORT_SYMBOL() when the provided API is reasonably "clean" (i.e. it hides the implementation well enough). Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
