On Mon, Feb 28, 2011 at 09:58:55AM -0500, Martin K. Petersen wrote: > >>>>> "Jeff" == Jeff Moyer <jmoyer@xxxxxxxxxx> writes: > > >> I have a proposal about 4k-sector hard drives support in fs drivers. > >> Toshiba MK1231GAL is an 1.8" LIF IDE drive. It has 4096-byte physical > >> and 512-byte logical sectors [1]. Unlike others drives with Advanced > >> Format, it has not read-modify-write logic, so it can only operate > >> with 4k blocks. Fortunately some filesystems in linux (I tested jfs, > > Jeff> Then it should report a logical block size of 4k. You have a > Jeff> drive with broken firmware. > > Several vendors are contemplating something similar. > > I.e. keep the 512-byte addressing to avoid implementing support for 4KB > logical blocks in the OS ATA stack. But the drive will reject I/Os that > are not naturally aligned multiples of 4KB. It's fine for them to do this; but if they do, they should be reporting a logical block size of 4k, yes? That's the definition of what logical block size means.... Ibragimov, the problem with your patch is that it means that users who had previously created a 1k block file system on an advanced format disk with 4k physical sectors but 512 byte logical sectors would no longer be able to mount that file system. Yes, it was stupid for them to do so, and they are deserving of plenty of mocking. But technically, it is something that should work, even if it's not advisable from a performance point of view. Maybe we can create a blacklist of broken drives that report a logical blocksize of 512 but which really have a logical block size of 4k? - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
