On Thu, Feb 10, 2011 at 07:22:47AM +1300, Charles Manning wrote: > Can you be a bit more specific? Just compare the mes in yaffs_linux.c with a normal linux filesystem. All that gross magic nfsd detection in readdir could have been removed long ago. ->readlink should not be implemented by a normal filesystem but use generic_readlink, the fs-specific inode should embedd the vfs inode instead of requiring two allocations, tons of useless function pointer indirections like sb_dirty_fn and the put_super_fn really must go away. The procfs interfaces should be replaced by something saner, the insane amount of ad-hoc tracing crap should be replaced by much less strategically placed trace events, and all those stupid compile time options have absolutely no business at all beeing there for a filesystem - remember you can get media from all over the place. If you can't encode these difference in your on-disk format it has absolutely no business going into mainline with this format. And last but not least there's no way we'll merge a filesystem with a global mutex and all kinds of hacky release and reaquire semantics these days. I really think you need to get back to the drawing board. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
