Re: [PATCH (resend)] fs: Fix dentry leak at dentry_open().

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 19, 2011 at 09:42:22AM +0900, Tetsuo Handa wrote:
> >From fa9c553a609cd2aa6703d733ced5e727896ac176 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> Date: Thu, 16 Sep 2010 18:37:42 +0900
> Subject: [PATCH] fs: Fix dentry leak at dentry_open().
> 
> dentry_open() says that it will have done dput(dentry) and mntput(mnt)
> if it returns an error. But it was not calling dput(dentry) when mnt == NULL.

NAK.  Turn that into BUG_ON(!mnt) and be done with that.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux