On Mon, 2011-01-17 at 16:13 -0800, Randy Dunlap wrote: > On 01/17/11 14:10, Nicholas A. Bellinger wrote: > > On Mon, 2011-01-17 at 10:24 -0800, Randy Dunlap wrote: > >> On Sun, 16 Jan 2011 22:05:54 -0800 Nicholas A. Bellinger wrote: > >> > >>> On Sun, 2011-01-16 at 18:22 -0600, James Bottomley wrote: > > > > <SNIP> > > > >>>> This is what I don't understand. > >>>> > >>>> Actually I think the whole premise of the patch (to get back to the > >>>> original topic) is wrong. > >>>> > >>>> TARGET_CORE depends on SCSI; SCSI has to have sysfs to survive ... we > >>>> just don't work without it yet we neither select nor depend on it. > >>>> SYSFS is only deselectable for embedded anyway, so I think the > >>>> configuration which generated this whole argument was likely a bogus one > >>>> and consequently, none of the patches are needed (or if they are, > >>>> they're the tip of the iceberg). > >>>> > >>> > >>> This sounds fine for TARGET_CORE, but would still leave GFS2_FS with an > >>> unmet direct dependency according to the original warning above. > >>> Unfortuately I do not recall which exactly linux-next build > >>> configuration was causing this warning to occur from the original post: > >>> > >>> http://marc.info/?l=linux-next&m=129355383112997&w=2 > >>> > >>> Any more thoughts here Randy..? > >> > >> > >> I've looked at GFS2 a bit now and I think that the warning is bogus: > >> > >> kconfig complains with: > >> warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS) > >> > >> but the "select" is conditional: > >> config GFS2_FS > >> tristate "GFS2 file system support" > >> depends on (64BIT || LBDAF) > >> select DLM if GFS2_FS_LOCKING_DLM > >> select CONFIGFS_FS if GFS2_FS_LOCKING_DLM > >> select SYSFS if GFS2_FS_LOCKING_DLM > >> > >> and the same condition selects both SYSFS and CONFIGFS_FS. Furthermore, the > >> conditional is not true, so neither of them is being selected/enabled. > >> Looks like a minor kconfig buglet to me. > >> > > > > Ok, so Linus has pulled the CONFIGFS_FS -> select SYSFS series and it > > looks like this 'select SYSFS ...' bit for GFS2_FS can safely be dropped > > now.. > > > > Care to carry this one via your kbuild tree..? > > > Who are you asking? (I don't have a kbuild tree.) > Err sorry, I thought you where feeding these types of kbuild/kconfig changes into mainline via your own tree. In that case, here is the patch committed into the LIO upstream tree and scsi-post-merge-2.6.git/for-linus branch. Thanks! >From 5ab4b07c2b516e23cafdc24b06d5cbfd44141ca9 Mon Sep 17 00:00:00 2001 From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> Date: Tue, 18 Jan 2011 00:40:31 +0000 Subject: [PATCH] gfs2: Remove 'select SYSFS ...' from Kconfig With CONFIGFS_FS now doing 'select SYSFS' by default, the extra 'select SYSFS if GFS2_FS_LOCKING_DLM' for GFS2_FS is now unnecessary. Reported-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> Signed-off-by: Nicholas A. Bellinger <nab@xxxxxxxxxxxxxxx> --- fs/gfs2/Kconfig | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/gfs2/Kconfig b/fs/gfs2/Kconfig index c465ae0..ff0a8eb 100644 --- a/fs/gfs2/Kconfig +++ b/fs/gfs2/Kconfig @@ -3,7 +3,6 @@ config GFS2_FS depends on (64BIT || LBDAF) select DLM if GFS2_FS_LOCKING_DLM select CONFIGFS_FS if GFS2_FS_LOCKING_DLM - select SYSFS if GFS2_FS_LOCKING_DLM select IP_SCTP if DLM_SCTP select FS_POSIX_ACL select CRC32 -- 1.7.3.5 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
