On Sun, Jan 16, 2011 at 10:44 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > On Sun, Jan 16, 2011 at 01:37:54PM -0800, Linus Torvalds wrote: >> On Sun, Jan 16, 2011 at 1:15 PM, Joachim ÂEastwood <manabian@xxxxxxxxx> wrote: >> > >> > f03c65993b98eeb909a4012ce7833c5857d74755 - sanitize vfsmount refcounting changes >> > >> > Breaks my ARM !CONFIG_SMP compile >> >> In fact, any non-SMP compile, it's not ARM-specific. >> >> The simple fix for the build breakage should be to just move the >> mnt_longterm thing out of the #ifdef CONFIG_SMP in >> include/linux/mount.h. But I do worry that it would cause some count >> imbalance, because there are some accesses that are still inside that >> CONFIG_SMP case in mntput_no_expire(). >> >> Al, please take a look, > > Already fixed. ÂActually, taking it out of ifdef would work (the only > place that actually cares about the value of that sucker is SMP side > of mntput()), but we are obviously better off just not touching it on > UP at all - why do pointless work and waste space? > > See the patch upthread. Â->mnt_longterm is SMP-only optimization of > mntput(); it's there only to free the common case of mntput() from > cacheline bouncing and on UP it's needed at all. > You push "mnt_longterm is there only on SMP" patch also for "for-next" GIT branch? - Sedat - -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
