David Howells <dhowells@xxxxxxxxxx> wrote: > It would be simpler, perhaps, to allow d_automount() to return the list also: > > struct vfsmount *(*d_automount)(struct path *mountpoint, > struct list_head **expiry_list_to_use); > > This pointer can then be passed directly to do_add_mount() and we don't have > to worry about having an extra reference or cleaning up the list on error. However, that isn't good enough as the filesystem may also need to start up the time-based expirer, which in the case of AFS, NFS and CIFS doesn't repeat if the list is empty - so if the mounting process gets preempted... David -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
