Re: [PATCH 01/18] Add a dentry op to handle automounting rather than abusing follow_link()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nick Piggin <npiggin@xxxxxxxxx> wrote:

> You still have to notice that it is .d_automount in rcu-walk mode, and bail
> out if it is. I can't see where you do that.

follow_managed(), and thus follow_automount() and ->d_automount(), are never
reached in rcu_walk mode, from what I can tell of the code.

There are two places follow_managed() is called:

 (1) do_lookup() - where follow_managed() is only called in the else-part of
     an if-statement contingent on a check of LOOKUP_RCU.

 (2) do_last() - where follow_managed() is subsequent to a mutex having been
     taken, so rcu-walk mode must have been exited prior to this as the
     process may have needed to sleep.

At least, I'm assuming you may not sleep whilst in rcu-walk mode.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux