On Thu, Jan 06, 2011 at 10:52:22PM +0100, Jesper Juhl wrote: > > In posix_acl_from_xattr() we have this at the head of the function: > > posix_acl_xattr_header *header = (posix_acl_xattr_header *)value; > posix_acl_xattr_entry *entry = (posix_acl_xattr_entry *)(header+1), *end; > > Since 'value' is passed in by the caller and may be NULL, the second line > looks suspicious to me - taking a potentially NULL pointer (at least > btrfs will pass something allocated with kmalloc() which may be NULL), > adding one to it and casting it does not seem like it would always be such > a hot idea. The original code is fine. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
