On Tue, Dec 21, 2010 at 7:25 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > On Tue, Dec 21, 2010 at 07:55:38PM +1100, Nick Piggin wrote: >> On Tue, Dec 21, 2010 at 09:44:40AM +0100, Sedat Dilek wrote: >> > Against linux-next (next-20101210) it should look like: >> >> Yep, I'll rebase my tree with the fix shortly. >> >> > >> > $ diff -Naur cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry.patch >> > cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry-v2.patch >> > --- cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry.patch >> > Â2010-12-21 09:31:38.649601964 +0100 >> > +++ cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry-v2.patch >> > Â2010-12-21 09:40:21.151033232 +0100 >> > @@ -83,7 +83,7 @@ >> > Â Â Â Â Â Â Â Â inode->i_size = 0; >> > Â Â Â Â Â Â Â Â inode->i_fop = &cgroup_file_operations; >> > Â Â Â Â } >> > -- Â Â Âdentry->d_op = &cgroup_dops; >> > +- Â Â Âd_set_d_op(dentry, &cgroup_dops); >> > Â Â Â Â d_instantiate(dentry, inode); >> > Â Â Â Â dget(dentry); Â /* Extra count - pin the dentry in core */ >> > Â Â Â Â return 0; > > How about not doing that d_set_d_op() at all? ÂSee #d_op in vfs-2.6.git; > just set ->s_d_op to that once and be done with that. ÂNo need to reassign > it on a live dentry... > The kernel mirrors are very slow since yesterday. Checking out and online-browsing your repo [1] is no fun. On a very quick view I don't see a cgroup fix. Can you please offer a revised full patch? Thanks in advance. Personally, I am glad to be able to use systemd, again. - Sedat - [1] http://git.kernel.org/?p=linux/kernel/git/viro/vfs-2.6.git;a=shortlog;h=refs/heads/d_op -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
