On Thu, Dec 16, 2010 at 10:09:38AM -0700, Andreas Dilger wrote: > On 2010-12-16, at 09:08, Anton Salikhmetov wrote: > > Make assignments outside `if' conditions for unicode.c module > > where the checkpatch.pl script reported this coding style error. > > Patches to do _only_ style cleanups are generally frowned upon. However, assignments in conditionals are potentially bug-inducing (either now, or if the code is modified in the future when the developer sees "==" when it actually has "="), so this patch is probably worthwhile. I'm not a big fan of pure cleanups either, but I'll suck in the whole series in the hope that this means hfsplus is done as far as cleanups are concerned from now on. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
