On 2010-12-13 16:04, Michał Mirosław wrote: > On Mon, Dec 13, 2010 at 02:38:19PM +0100, Jens Axboe wrote: >> On 2010-12-12 22:23, Michał Mirosław wrote: >>> This patch pulls calls to buf->ops->confirm() from all actors passed >>> (also indirectly) to splice_from_pipe_feed(). >> Why? The point of ->confirm() is to ensure that the contents are >> stable, otherwise the pages in the pipe could merely be in flight. >> It's needed if you need to actually look at the data, rather than just >> reference it. > > I should have put this more clearly in the patch description: > the ->confirm() call is moved to splice_from_pipe_feed(), so that every > actor has its data guaranteed to be stable before it runs. OK, that makes more sense. I'll queue it up. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
