Re: [PATCH] ext2: include fs.h in ext2_fs.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 03, 2010 at 10:26:26AM -0600, Eric Sandeen wrote:
> As reported by Cezary Sliwa in
> https://bugzilla.kernel.org/show_bug.cgi?id=24282
> ext2_fs.h references FS_DIRSYNC_FL etc, but does not
> include <linux/fs.h> to define them.  This seems ok
> for kernelspace builds, but breaks userspace applications
> which include ext2_fs.h.
> 
> Reported-by: Cezary Sliwa <sliwa@xxxxxxxxxxxxxxx>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

I wonder if we would be better off getting application programs weaned
off of trying to use the kernel's version of ext2_fs.h altogether.
E2fsprogs ships one which is going to be more uptodate, and works for
ext2/ext3/ext4.  Certainly if you plan to be using libext2fs (which I
would strongly advise for any program hoping to manipulate ext2
filesystem structures directly), you should be using the header file
shipped with e2fsprogs.

Debian and Ubuntu for example ships /usr/include/ext2fs/ext2_fs.h as
part of its e2fslibs-dev package.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux