Looks generally good to me. Two sugestions: - also trace the flags value and decode it using __print_flags in the output - use a dev_t instead of the split major/minor to follow the way the block layer, writeback and xfs tracepoints track the block device. Seems like this was copied from the recent conversion of ext4 away from it's braindead string printing, which didn't follow the existing way either. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
