>>>>> "Mark" == Mark Lord <kernel@xxxxxxxxxxxx> writes: Mark> But mke2fs probably is NOT doing a "single big discard", because Mark> for SATA the TRIM command is limited to 64K sectors per Mark> range.. and the in-kernel TRIM code only ever does single ranges.. How many times must I reiterate that this is not true? Due to various limitations in the way the block layer works we can not clear LBA 10 to 20 and LBA 40 to 50 in one command. We don't have an infrastructure in place that allows us to operate on several discrete areas in one request. But for contiguous areas we will cram as many ranges entries in as we can fit in the TRIM payload. This means we'll issue one TRIM command for every 2 GiB minus change (65535*64*512 / 1048576 = 2047 MiB). In your example above blkdev_issue_discard() will loop over the 100 GiB range requested by the caller (filesystem or BLKDISCARD ioctl) and issue about fifty TRIM commands to the drive. Large discards are a best-case scenario (short of SECURE ERASE). So if your drive takes forever to perform this operation then all bets are off in the TRIM department. Mark> So doing a discard over an entire drive-encompassing partition, Mark> say.. 100GB, will require 3000+ individual TRIM commands. No. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
