On Wed 24-11-10 15:56:33, Lukas Czerner wrote: > On Wed, 24 Nov 2010, Jan Kara wrote: > > + if (err < 0) { > > + if (err != -EOPNOTSUPP) > > + ext3_warning(sb, __func__, "Discard command " > > + "returned error %d\n", err); > > Maybe we can remove this warning completely and let use-space utility > handle and print out error message ? We could but at this point something strange is happening (ENOMEM, EIO, or something like that) so issuing a warning makes some sense. So I'd be maybe slightly in favor of keeping the warning. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html