On Wed, 2010-11-17 at 12:27 +0800, Wu Fengguang wrote: > @@ -555,8 +592,10 @@ static void balance_dirty_pages(struct a > pause = clamp_val(pause, 1, HZ/10); > > pause: > + bdi_update_write_bandwidth(bdi, &bw_time, &bw_written); > __set_current_state(TASK_INTERRUPTIBLE); > io_schedule_timeout(pause); > + bdi_update_write_bandwidth(bdi, &bw_time, &bw_written); > > /* > * The bdi thresh is somehow "soft" limit derived from the So its really a two part bandwidth calculation, the first call is: bdi_get_bandwidth() and the second call is: bdi_update_bandwidth() Would it make sense to actually implement it with two functions instead of overloading the functionality of the one function? -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
