On Mon, Nov 15, 2010 at 04:11:20PM +1100, Nick Piggin wrote: > This patch is totally broken. You can't just dget() a dentry with > nothing but RCU critical section open. The plain dget is indeed wrong as we should at least take d_lock and check d_count for zero before incrementing it to protect against shrink_dentry_list. I'm not quite sure it really matters as d_validate already has and always ad much worse bugs, such as the complete lack of protection against renames. Anyway, I'll send a patch to Linus to fix this issue for now. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html