On Tue, Nov 09, 2010 at 03:19:02PM +0100, Andi Kleen wrote: > Nick Piggin <npiggin@xxxxxxxxx> writes: > > > So here is the inode RCU code. It's obviously not worth doing until the > > actual rcu-walk path walking is in, but I'd like to get opinions on it. > > It would be nice to merge it in Al's tree at some point, though. > > I read the patch. It was quite monotonous (I guess that's a good thing) > But it wasn't clear to me why you added the INIT_LIST_HEAD()s > everywhere. Is this for stopping parallel walkers? > > Ok there's a comment in the doc: "VFS expects it to be initialized" > Is that really true today? I don't think the old code does that. It is in the inode_init_once pile, so yes it has to be returned to the allocator initialized. > > Other than that it seems straight forward. > > Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx> Thanks, Nick -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
