hi Marco > + retval = 0; > + out: > + if (retval && sbi->virt_addr) { > + iounmap(sbi->virt_addr); > + release_mem_region(sbi->phys_addr, initsize); > + } > + > + return retval; > +} Should add kfree(sbi) here in case of failure? -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html